gl: Properly report error if shader linking fails
authorAlexander Larsson <alexl@redhat.com>
Fri, 18 Sep 2020 09:34:14 +0000 (11:34 +0200)
committerAlexander Larsson <alexl@redhat.com>
Tue, 29 Sep 2020 07:51:16 +0000 (09:51 +0200)
In gsk_gl_shader_builder_create_program(), if linking fails we
need to return -1 to indicate error, rather than the old deleted
program id.

gsk/gl/gskglshaderbuilder.c

index a133527784a26de5e03e503367e07e4cb3119cea..66f0a3843e88f0638598ca7ffb458c66f8374445 100644 (file)
@@ -188,6 +188,7 @@ gsk_gl_shader_builder_create_program (GskGLShaderBuilder  *self,
       g_free (buffer);
 
       glDeleteProgram (program_id);
+      program_id = -1;
 
       goto out;
     }